A bi-weekly review club for LND PRs
What is this? A club for reviewing LND PRs every two weeks on Thursdays at 17:00 UTC in the #review-club channel on LND Developer Community Slack.
What’s it for? To help newer contributors learn about the LND review process. The review club is not primarily intended to help open PRs get merged (although that might be a nice side-effect).
Who should take part? Anyone who wants to learn about contributing to LND. All are welcome to come and ask questions!
What’s the benefit for participants? Reviewing and testing PRs is the best way to start contributing to LND, but it’s difficult to know where to start. There are hundreds of open PRs, many require a lot of contextual knowledge, and contributors and reviewers often use unfamiliar terminology. The review club will give you the tools and knowledge you need in order to take part in the LND review process on GitHub.
Who runs this? Lightning Labs evangelist lucasdcf started the review club and schedules the upcoming meetings. Individual meetings are hosted by a variety of LND contributors. See some of our previous hosts.
|06 Oct 2022||»||#6914 addinvoice: refactor hint hop selection algorithm (invoices) hosted by positiveblue|
We’re always looking for interesting PRs to discuss in the review club and for volunteer hosts to lead the discussion:
- To suggest a PR, please DM @lucasdcf on Slack or Twitter.
- If you’d like to host a meeting, contact lucasdcf on on Slack or Twitter.
|22 Sep 2022||»||#6759 itest: start a scaffolding testing framework (itests) hosted by yyforyongyu|
|08 Sep 2022||»||#6753 lncli: base_fee_msat and fee_rate_ppm for openchannel (funding) hosted by sputn1ck|
|11 Aug 2022||»||#6683 channeldb+routing: refactor payment lifecycle (routing) hosted by positiveblue|
See all meetings.
Other Resources for New Contributors
- Read the Contributing to LND Guide. This will help you understand the process and some of the terminology we use in LND.
- Look at the Good First Issues and Up For Grabs list.