A bi-weekly review club for LND PRs

What is this?  A club for reviewing LND PRs every two weeks on Thursdays at 17:00 UTC in the #review-club channel on LND Developer Community Slack.

What’s it for?  To help newer contributors learn about the LND review process. The review club is not primarily intended to help open PRs get merged (although that might be a nice side-effect).

Who should take part?  Anyone who wants to learn about contributing to LND. All are welcome to come and ask questions!

What’s the benefit for participants?  Reviewing and testing PRs is the best way to start contributing to LND, but it’s difficult to know where to start. There are hundreds of open PRs, many require a lot of contextual knowledge, and contributors and reviewers often use unfamiliar terminology. The review club will give you the tools and knowledge you need in order to take part in the LND review process on GitHub.

How do I take part? Just show up on Slack! See Attending your first PR Review Club for more tips on how to participate.

Who runs this?  Lightning Labs evangelist lucasdcf started the review club and schedules the upcoming meetings. Individual meetings are hosted by a variety of LND contributors. See some of our previous hosts.

Upcoming Meetings

» #4029 Adds `fundmax` flag to `openchannel` (funding) hosted by bjarnemagnussen
» #6335 routerrpc: TrackPayments (TBD) hosted by yyforyongyu
» #5335 Return `FEE_INSUFFICIENT` before checking balance for incoming low-fee HTLCs (htlcswitch) hosted by arshbot

We’re always looking for interesting PRs to discuss in the review club and for volunteer hosts to lead the discussion:

Recent Meetings

» #5700 Multi+refactor: persistent peer manager (p2p) hosted by guggero

See all meetings.

Other Resources for New Contributors