lncli: base_fee_msat and fee_rate_ppm for openchannel (funding)


Host: sputn1ck  -  PR author: hieblmi


  • No notes


  • Did you review the PR? If yes, what’s your overall verdict? (ACK, NACK, concept ACK, unknown)
  • What do you like about the PR comment/message?
  • Did you do a test with lncli? Do you like the UX of the new command? What was your workflow like?
  • What is a ‘sink’ node?
  • What problems could a user face when opening a channel to a sink node?
  • Why do we need the boolean fields UseBaseFee UseFeeRate in the updated OpenChannelRequest?
  • What options do we have for adding new fields to existing DB objects?
  • What do we want to store and for how long?
  • Where are we storing the feerates?
  • With regards to the channel funding flow, when and in what message do we send the feerates?
  • When someone opens a channel to us, we use the static fee values of our lnd.conf. How could we add a similiar logic to this PR for receiving a channel request?